Skip to content

Conversation

@ararslan
Copy link
Member

Reverts #484 per #484 (comment).

We can't build 1.12.0-rc3 binaries for Windows due to -Werror.

@DilumAluthge DilumAluthge added the automerge Kodiak will auto-merge this PR once all CI is green. (This label was previously called "merge me".) label Sep 27, 2025
@kodiakhq kodiakhq bot merged commit b20808d into main Sep 27, 2025
6 of 7 checks passed
@kodiakhq kodiakhq bot deleted the revert-484-ct/windows-Werror branch September 27, 2025 05:31
@ararslan
Copy link
Member Author

@DilumAluthge, do you know whether anything else needs to happen in order for this to take effect? I retried the Windows builds for v1.12.0-rc3 and both failed on warnings with -Werror again.

@DilumAluthge
Copy link
Member

Hmmm. Can you try deleting and recreating the tag?

@ararslan
Copy link
Member Author

I retried the builds again to see if they miraculously work this time but if not then I'll try that.

@DilumAluthge
Copy link
Member

@ararslan Did it end up working after another retry?

@ararslan
Copy link
Member Author

Nope, perhaps unsurprisingly. I deleted and recreated the tag as you suggested and am still waiting for the Windows builds from that to start.

@DilumAluthge
Copy link
Member

Once you've confirmed that the Windows builds succeeded, let me know, and I'll create Buildkite release branches for 1.{10-12}

@ararslan
Copy link
Member Author

Windows builds succeeded and tests nearing completion! 🎉

@ararslan
Copy link
Member Author

We're all good now. Thanks so much for your help, @DilumAluthge!

@topolarity
Copy link
Contributor

Thanks for fixing this up folks! (sorry for the breakage)

Any progress with splitting this so that we can un-revert on julialang/master?

@DilumAluthge
Copy link
Member

Any progress with splitting this so that we can un-revert on julialang/master?

I'll work on creating the release branches, after which we can re-land.

@DilumAluthge
Copy link
Member

DilumAluthge commented Oct 6, 2025

I've pushed release branches to this repo for:

  • release-julia.1.10
  • release-julia-1.11
  • release-julia-1.12

But we won't actually start using those branches until the corresponding PRs are merged:

@DilumAluthge
Copy link
Member

I'm going to wait to merge JuliaLang/julia#59759 until after 1.12.0 has been released, to avoid breaking anything during this last part of the release process.

And we should hold off on re-landing #484 until after JuliaLang/julia#59759 has been merged.

@ararslan
Copy link
Member Author

Would it make sense for the branch names to match those on the Julia repo? So e.g. release-1.12 instead of release-julia-1.12. Probably doesn't matter

@DilumAluthge
Copy link
Member

Would it make sense for the branch names to match those on the Julia repo? So e.g. release-1.12 instead of release-julia-1.12. Probably doesn't matter

IIRC, this was intentional, to avoid confusion between branches in JuliaLang/julia and branches in JuliaCI/julia-buildkite.

@DilumAluthge
Copy link
Member

Alright, all three backports branches are now using the release-julia-* branches in this repo.

Specifically:

  1. Julia 1.10: JuliaLang/julia@6901dde is included in Backports for Julia 1.10.11 JuliaLang/julia#58889
  2. Julia 1.11: JuliaLang/julia@58327cc is included in Backports for Julia 1.11.8 JuliaLang/julia#59521
  3. Julia 1.12: JuliaLang/julia@bac8fca is included in Backports for 1.12.1 JuliaLang/julia#59705

@topolarity Can you re-land your PR now?

kodiakhq bot pushed a commit that referenced this pull request Nov 4, 2025
Re-land #484 (as
requested in
#487 (comment))

This will need the treehashes to be signed again.

---------

Co-authored-by: Ian Butterworth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Kodiak will auto-merge this PR once all CI is green. (This label was previously called "merge me".)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants