-
Notifications
You must be signed in to change notification settings - Fork 19
Revert "Use -Werror (with exceptions) on Windows builds"
#487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 32e5db8.
|
@DilumAluthge, do you know whether anything else needs to happen in order for this to take effect? I retried the Windows builds for v1.12.0-rc3 and both failed on warnings with |
|
Hmmm. Can you try deleting and recreating the tag? |
|
I retried the builds again to see if they miraculously work this time but if not then I'll try that. |
|
@ararslan Did it end up working after another retry? |
|
Nope, perhaps unsurprisingly. I deleted and recreated the tag as you suggested and am still waiting for the Windows builds from that to start. |
|
Once you've confirmed that the Windows builds succeeded, let me know, and I'll create Buildkite release branches for 1.{10-12} |
|
Windows builds succeeded and tests nearing completion! 🎉 |
|
We're all good now. Thanks so much for your help, @DilumAluthge! |
|
Thanks for fixing this up folks! (sorry for the breakage) Any progress with splitting this so that we can un-revert on |
I'll work on creating the release branches, after which we can re-land. |
|
I've pushed release branches to this repo for:
But we won't actually start using those branches until the corresponding PRs are merged:
|
|
I'm going to wait to merge JuliaLang/julia#59759 until after 1.12.0 has been released, to avoid breaking anything during this last part of the release process. And we should hold off on re-landing #484 until after JuliaLang/julia#59759 has been merged. |
|
Would it make sense for the branch names to match those on the Julia repo? So e.g. |
IIRC, this was intentional, to avoid confusion between branches in JuliaLang/julia and branches in JuliaCI/julia-buildkite. |
|
Alright, all three backports branches are now using the Specifically:
@topolarity Can you re-land your PR now? |
Re-land #484 (as requested in #487 (comment)) This will need the treehashes to be signed again. --------- Co-authored-by: Ian Butterworth <[email protected]>
Reverts #484 per #484 (comment).
We can't build 1.12.0-rc3 binaries for Windows due to
-Werror.